brainstorming
brainstorming
You MUST use this before any creative work - creating features, building components, adding functionality, modifying behavior, or planning anything new, in software or out of it (a talk, a business, a renovation).
reviewCode review for PRs or staged changes. >80% confidence threshold. Verdict: APPROVE, REQUEST CHANGES, or COMMENT. Triggers: review, pr, code review.
Independent GitHub snapshot · Automated classification · Original documentation governs
Load: skills/build/reference/testing.md, skills/tearitapart/reference/security.md Reference: _meta/research/ai-code-anti-patterns.md
priority: check Big 5 first (what AI actually breaks)
<on_start>
agentdb read-start
<identify_scope>
gh pr diff {number} # For PRs
git diff --staged # For staged
git diff HEAD~1 # For recent
</identify_scope>
<deterministic_lane> Machines first, then judgment. Run before reading a single diff hunk:
"${CLAUDE_PLUGIN_ROOT:-.}/scripts/deterministic-review.sh" <repo-dir> [base-ref]
Parallel gitleaks / semgrep(p/security-audit) / eslint / ruff / shellcheck / actionlint / zizmor / osv-scanner — whatever is installed; diff-scoped when base-ref given; exit 1 on HIGH (secrets, security SAST, high CVEs). Feed findings.tsv into the review as ground truth. Lanes marked SKIPPED are reported as NOT CHECKED, never as clean. </deterministic_lane> </on_start>
<confidence_threshold>
| Confidence | Category | Report? |
|---|---|---|
| 95%+ | Definite bug | YES |
| 85-95% | Likely issue | YES |
| 70-85% | Possible issue | MAYBE |
| <70% | Style preference | NO |
| </confidence_threshold> |
<refute_before_report> Before a finding enters the report, check it against reference/refutation-patterns.md (11 false-alarm families + 5 refutation moves). A finding matching a family needs evidence distinguishing it from the refuted precedent. Severity gates from the same file apply: falsification check before CRITICAL, consensus deflation, authority stripping on CVEs, and the judge's own additions get refuted too. Refuted candidates go in the report WITH their refutations; if the project keeps a refutation-corpus file, append new refuted false alarms to it in the same session. </refute_before_report>
Files: X changed Findings: Y (Z critical)
[file:line] Issue (confidence: XX%) → Fix: suggestion
[file:line] Issue (confidence: XX%) → Fix: suggestion
Summary: APPROVE | REQUEST CHANGES | COMMENT </output_format>
<ask_user> Use AskUserQuestion when: a finding is between 70-85% confidence (ambiguous) Ask: "Found {issue} at {file:line} (confidence {X}%). Intentional, or should I flag it?" Options: intentional — skip, flag it, investigate deeper </ask_user>
<verdict_rules> Review is finite because its purpose is AUTHORIZATION, not exhaustion. Approve once the change improves the health of the codebase, not once nothing else can be found. Nothing else can ever be found. (#204)
<block_bar> A finding blocks only with ALL of:
dimension, and let the profile's
blocks_at map decide the threshold for that dimension. A production-hardening finding on a
demo is not a blocker however real it is, and a privacy finding on a demo IS one when the
profile says so. The stage label never decides; the dimensions do.Everything else is filed with its distance:N label under the quarantine milestone. Recurrence
is signal, silence is a verdict.
Complexity clears the block bar only when changed code exceeds a declared budget, a regression
diff names the increase, or the acceptance record requires the project gate and that armed path
does not run it. A lizard result over JS/TS object-literal methods cannot support APPROVE or FAIL;
it is NOT CHECKED until an AST-aware parser runs.
</block_bar>
Read the acceptance record before reviewing: claims, declared invariants, and tradeoffs already
accepted. If the commit carries one, it is FROZEN and adjudication will refuse a FAIL. Reopening
takes new_failing_input, changed_dependency, missed_requirement, disproven_assumption,
profile_changed, or owner_promotion. A new reviewer is not a reopen event.
Never ask a reviewer whether criticism is complete; it cannot answer and will always say no.
An acceptance-profile review never ships ALONE. Pair it with one outcome-shaped discovery pass
(DISCOVERY AXIS: outcome) that never receives the profile, invariants, or ACCEPT WHEN list.
Measured (EXP-RTP1 variant M, #206): on a real defect the contract never names, the bounded
reviewer caught it 0/20 and returned PASS 18/20, while the open reviewer caught it 18/19. The
contract terminates review; alone it certifies what it was never told to see.
</verdict_rules>
<on_complete>
Emit findings as a kernel.verdict/v1 document and let the acceptance function decide. The
reviewer never grades its own completeness.
python3 scripts/adjudicate.py findings.json --text --strict # 0 PASS · 1 FAIL · 2 INVALID
agentdb write-end '{"command":"review","verdict":"X","critical":N,"high":N,"big5_violations":N,"quarantined":N}'
cannot_falsify is mandatory and non-empty. State what this review structurally could not see
(no real device, conformance only, no live data, a suite that did not finish). Silence about
coverage reads as coverage.
</on_complete>